Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 617513003: Makes NativeViewport send OnBoundsChanged() after widget available (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Makes NativeViewport send OnBoundsChanged() after widget available It was possible for us to send it before. BUG=none TEST=none R=ben@chromium.org, darin@chromium.org Committed: https://crrev.com/5b19be3a063c7dd7ab0d414030750c733e6d9c56 Cr-Commit-Position: refs/heads/master@{#297472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -7 lines) Patch
M mojo/public/cpp/bindings/callback.h View 8 chunks +32 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/callback.h.pump View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/shared_ptr.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.cc View 5 chunks +20 lines, -6 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
ben: native_viewport darin: the rest
6 years, 2 months ago (2014-09-29 17:49:16 UTC) #1
darin (slow to review)
LGTM for mojo/public
6 years, 2 months ago (2014-09-29 23:34:06 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-09-30 16:37:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617513003/1
6 years, 2 months ago (2014-09-30 16:40:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4f605f2e1192452c533da7841045d184a83eb1e7
6 years, 2 months ago (2014-09-30 19:06:36 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 19:07:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b19be3a063c7dd7ab0d414030750c733e6d9c56
Cr-Commit-Position: refs/heads/master@{#297472}

Powered by Google App Engine
This is Rietveld 408576698