Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 617503003: Mojo: MOJO_OVERRIDE -> override in mojo/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: MOJO_OVERRIDE -> override in mojo/. Keep MOJO_OVERRIDE around very temporarily, since there are a few users of it outside of mojo/. (The change was clang-format'ed.) R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ddc0b03bf29e83034b1cccbed44b63d56ad79683

Patch Set 1 #

Patch Set 2 : fix nacl? #

Patch Set 3 : fix nacl v2 #

Patch Set 4 : undo nacl changes #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -387 lines) Patch
M mojo/application_manager/application_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/apps/js/application_delegate_impl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/dbus/dbus_external_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/apptest/example_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/apptest/example_client_application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/apptest/example_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/apptest/example_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/apptest/example_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/view_manager_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/browser/browser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/content_handler_demo/content_handler_demo.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/examples/dbus_echo/dbus_echo_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/demo_launcher/demo_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/echo/echo_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/echo/echo_service.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/keyboard/keyboard.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/png_viewer/png_viewer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/wget/wget.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/wm_flow/app/app.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/examples/wm_flow/embedded/embedded.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/wm_flow/init/init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wm_flow/wm/frame_controller.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 1 2 3 4 7 chunks +15 lines, -17 lines 0 comments Download
M mojo/public/c/system/tests/core_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/application_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/interface_factory_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.h View 1 chunk +6 lines, -7 lines 0 comments Download
M mojo/public/cpp/application/lib/weak_service_provider.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/tests/service_registry_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/callback.h View 8 chunks +15 lines, -18 lines 0 comments Download
M mojo/public/cpp/bindings/callback.h.pump View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/connector.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/message_header_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/no_interface.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 8 chunks +11 lines, -15 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 7 chunks +10 lines, -21 lines 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M mojo/public/cpp/environment/lib/default_async_waiter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/system/macros.h View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/public/cpp/system/tests/macros_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/utility/tests/mutex_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/utility/tests/run_loop_unittest.cc View 8 chunks +10 lines, -16 lines 0 comments Download
M mojo/public/cpp/utility/tests/thread_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/public/python/src/python_system_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_request_validator_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_response_validator_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/services/clipboard/clipboard_standalone_impl.h View 1 chunk +6 lines, -9 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager_client_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_request_tracker_impl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/services/test_service/test_service_application.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/test_service/test_service_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/window_manager/main.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 5 chunks +18 lines, -27 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 2 3 4 2 chunks +15 lines, -17 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/shell/context.cc View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/shell/external_application_listener_posix.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/external_application_listener_posix.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/external_application_listener_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/incoming_connection_listener_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/shell/run.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/tools/package_manager/package_manager_application.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
viettrungluu
6 years, 2 months ago (2014-09-29 17:20:33 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-09-29 17:24:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617503003/1
6 years, 2 months ago (2014-09-29 17:30:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617503003/20001
6 years, 2 months ago (2014-09-29 17:52:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617503003/60001
6 years, 2 months ago (2014-09-29 19:24:00 UTC) #12
commit-bot: I haz the power
Failed to apply patch for mojo/services/window_manager/window_manager_app.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-09-29 20:35:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617503003/80001
6 years, 2 months ago (2014-09-29 20:50:09 UTC) #16
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/ddc0b03bf29e83034b1cccbed44b63d56ad79683 Cr-Commit-Position: refs/heads/master@{#297252}
6 years, 2 months ago (2014-09-29 20:51:28 UTC) #18
viettrungluu
6 years, 2 months ago (2014-09-29 20:51:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
ddc0b03bf29e83034b1cccbed44b63d56ad79683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698