components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java - Issue 617393005: Make URLRequestContextAdapter initialization asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 617393005: Make URLRequestContextAdapter initialization asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

index 4c3dd44ffca2552a946ab95e2b1425d0d2c81e1f..92dbddf07915ce3ab45c6810c5b2f9aa9daf075c 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

@@ -37,11 +37,9 @@ public class ChromiumUrlRequestContext {

String config) {

mChromiumUrlRequestContextAdapter = nativeCreateRequestContextAdapter(

context, userAgent, getLoggingLevel(), config);

- if (mChromiumUrlRequestContextAdapter == 0)

+ if (mChromiumUrlRequestContextAdapter == 0) {

throw new NullPointerException("Context Adapter creation failed");

- // TODO(mef): Revisit the need of block here.

- mStarted.block(2000);

+ }

}

/**

« no previous file with comments | « no previous file | components/cronet/android/url_request_adapter.cc » ('j') | components/cronet/android/url_request_adapter.cc » ('J')