Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 617353007: Add support for signing HTTPS with self-signed root certificate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
index c95555f0dbb500beeb797b805508364bbd35ac40..33d6b7005169bd57a79085768b8719a2296453d8 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
@@ -139,7 +139,12 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
not self.browser_options.netsim)
http_remote_port = self.wpr_port_pairs.http.remote_port
https_remote_port = self.wpr_port_pairs.https.remote_port
- replay_args = ['--ignore-certificate-errors']
+ replay_args = []
+ if not self.wpr_ca_cert_path:
+ # Ignore certificate errors if the browser backend has not created
+ # and installed a root certificate. When |self.wpr_ca_cert_path| is
+ # set, Web Page Replay uses it to sign HTTPS responses.
+ replay_args.append('--ignore-certificate-errors')
if use_host_resolver:
replay_args.append('--host-resolver-rules=MAP * %s,EXCLUDE localhost' %
self.forwarder_factory.host_ip) # replay's host_ip
« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/wpr_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698