Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 617353003: fix prev change to tooBigForLCD, and add test (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix prev change to tooBigForLCD, and add test BUG=skia: Committed: https://skia.googlesource.com/skia/+/4942e7550ec80796132ab1ce2cc935a5dd1b464c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -21 lines) Patch
M gm/lcdtext.cpp View 3 chunks +73 lines, -16 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
ptal
6 years, 2 months ago (2014-10-01 20:50:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617353003/1
6 years, 2 months ago (2014-10-01 20:51:18 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-01 20:51:19 UTC) #5
bungeman-skia
lgtm
6 years, 2 months ago (2014-10-01 20:55:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 20:59:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 4942e7550ec80796132ab1ce2cc935a5dd1b464c

Powered by Google App Engine
This is Rietveld 408576698