Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 617333003: Reland: Pass initDataType instead of contentType to OnNeedKey(). (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, eme-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland: Pass initDataType instead of contentType to OnNeedKey(). BUG=224786 Cr-Commit-Position: refs/heads/master@{#297523} (cherry picked from commit 2983dc91cc0bc7be6014f4bfc5cb19cc6e262a0b) Committed: https://crrev.com/22851a415bff2a92fa24c2794ffc768188137a3c Cr-Commit-Position: refs/heads/master@{#297872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/encrypted_media_player_support_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.cc View 2 chunks +1 line, -12 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/webm/webm_crypto_helpers.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-10-01 20:17:16 UTC) #2
ddorwin
Description nits: * s/Revert revert/Reland/ * "The layout test that caused the revert has been ...
6 years, 2 months ago (2014-10-01 21:07:13 UTC) #3
sandersd (OOO until July 31)
No changes, this should work now that the layout test has been updated. (https://src.chromium.org/viewvc/blink?view=rev&revision=183020) Revert ...
6 years, 2 months ago (2014-10-01 21:09:10 UTC) #4
ddorwin
Thanks. rsLGTM of cherry-pick - I briefly skimmed it.
6 years, 2 months ago (2014-10-01 21:15:01 UTC) #5
ddorwin
^LGTM
6 years, 2 months ago (2014-10-01 21:15:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617333003/1
6 years, 2 months ago (2014-10-02 17:52:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3ede2a91982fe5863e4427c371192551ef751e38
6 years, 2 months ago (2014-10-02 18:49:58 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:50:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22851a415bff2a92fa24c2794ffc768188137a3c
Cr-Commit-Position: refs/heads/master@{#297872}

Powered by Google App Engine
This is Rietveld 408576698