Index: PRESUBMIT.py |
diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
index 75e16e3bd79df3876e046983ee9c645cde0c9be0..fe15157dde7f7e237bb85a77725f6e08b89c3714 100644 |
--- a/PRESUBMIT.py |
+++ b/PRESUBMIT.py |
@@ -69,15 +69,28 @@ def _SkipTreeCheck(input_api, output_api): |
return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip' |
+def _CheckChangeLogFlag(input_api, output_api): |
+ """Checks usage of LOG= flag in the commit message.""" |
+ results = [] |
+ if input_api.change.BUG and not 'LOG' in input_api.change.tags: |
+ results.append(output_api.PresubmitError( |
+ 'An issue reference (BUG=) requires a change log flag (LOG=). ' |
+ 'Use LOG=Y for including this commit message in the change log. ' |
+ 'Use LOG=N or leave blank otherwise.')) |
+ return results |
+ |
+ |
def CheckChangeOnUpload(input_api, output_api): |
results = [] |
results.extend(_CommonChecks(input_api, output_api)) |
+ results.extend(_CheckChangeLogFlag(input_api, output_api)) |
return results |
def CheckChangeOnCommit(input_api, output_api): |
results = [] |
results.extend(_CommonChecks(input_api, output_api)) |
+ results.extend(_CheckChangeLogFlag(input_api, output_api)) |
results.extend(input_api.canned_checks.CheckChangeHasDescription( |
input_api, output_api)) |
if not _SkipTreeCheck(input_api, output_api): |