Issue 61733021: Reland "Harden NumberToSize against overflows."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61733021: Reland "Harden NumberToSize against overflows." (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)

Modified:
7 years, 1 month ago

Reviewers:
ulan, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland "Harden NumberToSize against overflows." The callers to NumberToSize are supposed to validate the number, but this adds a last line of defense. TBR=jkummerow@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17737

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/v8conversions.h	View		1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

Committed patchset #1 manually as r17737 (presubmit successful).

7 years, 1 month ago (2013-11-14 11:40:39 UTC) #2

Message was sent while issue was closed.

lgtm