Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 61733011: Specify --patchlevel 0 to trychange.py (Closed)

Created:
7 years, 1 month ago by borenet
Modified:
7 years, 1 month ago
Reviewers:
epoger, rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Specify --patchlevel 0 to trychange.py For some reason, trychange.py creates patches with level 0, even from a git repo. We were assuming that the patch level was 1 from a git repo, so patches were failing to apply. BUG=skia:1669 R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=12212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/submit_try View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
borenet
7 years, 1 month ago (2013-11-08 20:43:55 UTC) #1
rmistry
LGTM
7 years, 1 month ago (2013-11-11 12:08:47 UTC) #2
borenet
Committed patchset #1 manually as r12212 (presubmit successful).
7 years, 1 month ago (2013-11-11 13:43:33 UTC) #3
epoger
7 years, 1 month ago (2013-11-11 19:10:14 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698