Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: trunk/Source/config.gyp

Issue 61733005: Revert 161469 "Enable chromium_code=1 on Windows" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/Source/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/config.gyp
===================================================================
--- trunk/Source/config.gyp (revision 161481)
+++ trunk/Source/config.gyp (working copy)
@@ -43,11 +43,8 @@
'..',
],
'msvs_disabled_warnings': [
- 4138, 4244, 4291, 4305, 4344, 4355, 4521, 4099, 4800, 4996, 4714,
+ 4138, 4244, 4291, 4305, 4344, 4355, 4521, 4099,
],
- 'variables': {
- 'chromium_code': 1,
- },
'conditions': [
['OS=="win" and component=="shared_library"', {
'defines': [
@@ -92,6 +89,12 @@
# timesNewRoman.unstatic.3258 and colorTransparent.unstatic.4879.
'cflags': ['-Wno-uninitialized'],
}],
+ ['OS!="win"', {
+ # TODO: Turn this on on all platforms, http://crbug.com/312287
+ 'variables': {
+ 'chromium_code': 1,
+ },
+ }],
['clang==1', {
'cflags': ['-Wglobal-constructors'],
'xcode_settings': {
« no previous file with comments | « no previous file | trunk/Source/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698