Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 617323002: Revert of Fix ChromeVox Next compile. (Closed)

Created:
6 years, 2 months ago by David Tseng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Revert of Fix ChromeVox Next compile. (patchset #3 id:30001 of https://codereview.chromium.org/613223003/) Reason for revert: Still causing errors in compile. Original issue's description: > Fix ChromeVox Next compile. > > Committed: https://crrev.com/f72920ef659207f761f8b8233fb597391fc609a8 > Cr-Commit-Position: refs/heads/master@{#297541} TBR=dmazzoni@chromium.org,plundblad@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/73d3602e7b54b80fbc24d8afda8e5819b04ae2f3 Cr-Commit-Position: refs/heads/master@{#297663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -150 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 2 chunks +1 line, -89 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 6 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 6 chunks +13 lines, -17 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/cvox2/background/externs.js View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
David Tseng
Created Revert of Fix ChromeVox Next compile.
6 years, 2 months ago (2014-10-01 16:59:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617323002/1
6 years, 2 months ago (2014-10-01 17:00:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8269960d9bc6295421439d17020d88a80368ccd7
6 years, 2 months ago (2014-10-01 17:02:07 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 17:02:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73d3602e7b54b80fbc24d8afda8e5819b04ae2f3
Cr-Commit-Position: refs/heads/master@{#297663}

Powered by Google App Engine
This is Rietveld 408576698