Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 617293002: Speeding up WebRTC content_browsertests by not rendering video. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Speeding up WebRTC content_browsertests by not rendering video. I noticed signficant speed-up on my machine by not renderering the video element on the page, and the tests don't seem to care (they can still dig out pixels with video+canvas grabbing). It would be better if we could remove EnablePixelOutput and not render anything at all, but unfortunately that seems to break video+canvas grabbing on non-GPU bots. BUG=417756 Committed: https://crrev.com/5d572d101ed29547716bca58a46f3e32d2e40fed Cr-Commit-Position: refs/heads/master@{#297676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M content/test/data/media/getusermedia.html View 1 chunk +2 lines, -8 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 chunk +10 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund_chromium
6 years, 2 months ago (2014-10-01 15:00:24 UTC) #2
kjellander_chromium
lgtm
6 years, 2 months ago (2014-10-01 15:51:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617293002/1
6 years, 2 months ago (2014-10-01 16:01:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 992dd4d28c10dcab4df83d65dac604fdeae7ceca
6 years, 2 months ago (2014-10-01 18:11:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 18:13:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d572d101ed29547716bca58a46f3e32d2e40fed
Cr-Commit-Position: refs/heads/master@{#297676}

Powered by Google App Engine
This is Rietveld 408576698