Introduce v8::Object::GetIsolate().

Introduce v8::Object::GetIsolate().

API=v8::Object::GetIsolate()
LOG=Y
R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24376

[aandrey, 2014-10-01 13:21:01]

aandrey@chromium.org changed reviewers:
+ aandrey@chromium.org

[aandrey, 2014-10-01 13:21:02]

https://codereview.chromium.org/617263003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/617263003/diff/1/src/api.cc#newcode5611
src/api.cc:5611: Isolate* v8::Object::GetIsolate() {
v8::Value ?

[Yang, 2014-10-01 13:37:23]

On 2014/10/01 13:21:02, aandrey wrote:
> https://codereview.chromium.org/617263003/diff/1/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/617263003/diff/1/src/api.cc#newcode5611
> src/api.cc:5611: Isolate* v8::Object::GetIsolate() {
> v8::Value ?

unfortunately we can't get the isolate from a Smi, which belongs to v8::Value.

[aandrey, 2014-10-01 13:45:38]

On 2014/10/01 13:37:23, Yang wrote:
> On 2014/10/01 13:21:02, aandrey wrote:
> > https://codereview.chromium.org/617263003/diff/1/src/api.cc
> > File src/api.cc (right):
> > 
> > https://codereview.chromium.org/617263003/diff/1/src/api.cc#newcode5611
> > src/api.cc:5611: Isolate* v8::Object::GetIsolate() {
> > v8::Value ?
> 
> unfortunately we can't get the isolate from a Smi, which belongs to v8::Value.

In all v8::Value methods we cast "this" to i::Handle<i::Object>, so
if we just replace v8::Object::GetIsolate to v8::Value::GetIsolate it will
compile, right?

We can return nullptr isolate for some Value's, or CurrentIsolate.

bool Value::IsInt32() const {
  i::Handle<i::Object> obj = Utils::OpenHandle(this);
  if (obj->IsSmi()) return true;
  // ...
}

[aandrey, 2014-10-01 13:48:29]

On 2014/10/01 13:45:38, aandrey wrote:
> On 2014/10/01 13:37:23, Yang wrote:
> > On 2014/10/01 13:21:02, aandrey wrote:
> > > https://codereview.chromium.org/617263003/diff/1/src/api.cc
> > > File src/api.cc (right):
> > > 
> > > https://codereview.chromium.org/617263003/diff/1/src/api.cc#newcode5611
> > > src/api.cc:5611: Isolate* v8::Object::GetIsolate() {
> > > v8::Value ?
> > 
> > unfortunately we can't get the isolate from a Smi, which belongs to
v8::Value.
> 
> In all v8::Value methods we cast "this" to i::Handle<i::Object>, so
> if we just replace v8::Object::GetIsolate to v8::Value::GetIsolate it will
> compile, right?
> 
> We can return nullptr isolate for some Value's, or CurrentIsolate.
> 
> bool Value::IsInt32() const {
>   i::Handle<i::Object> obj = Utils::OpenHandle(this);
>   if (obj->IsSmi()) return true;
>   // ...
> }

Nevermind. GetIsolate is method of HeapObject, not Object.

[aandrey, 2014-10-01 13:52:20]

On 2014/10/01 13:48:29, aandrey wrote:
> On 2014/10/01 13:45:38, aandrey wrote:
> > On 2014/10/01 13:37:23, Yang wrote:
> > > On 2014/10/01 13:21:02, aandrey wrote:
> > > > https://codereview.chromium.org/617263003/diff/1/src/api.cc
> > > > File src/api.cc (right):
> > > > 
> > > > https://codereview.chromium.org/617263003/diff/1/src/api.cc#newcode5611
> > > > src/api.cc:5611: Isolate* v8::Object::GetIsolate() {
> > > > v8::Value ?
> > > 
> > > unfortunately we can't get the isolate from a Smi, which belongs to
> v8::Value.
> > 
> > In all v8::Value methods we cast "this" to i::Handle<i::Object>, so
> > if we just replace v8::Object::GetIsolate to v8::Value::GetIsolate it will
> > compile, right?
> > 
> > We can return nullptr isolate for some Value's, or CurrentIsolate.
> > 
> > bool Value::IsInt32() const {
> >   i::Handle<i::Object> obj = Utils::OpenHandle(this);
> >   if (obj->IsSmi()) return true;
> >   // ...
> > }
> 
> Nevermind. GetIsolate is method of HeapObject, not Object.

Although this won't allow to get isolate for an Oddball object (undefined,
null).

[Sven Panne, 2014-10-01 14:30:19]

lgtm

[Yang, 2014-10-02 06:52:48]

Committed patchset #1 (id:1) manually as 24376 (presubmit successful).