Support WebServiceWorkerResponseType in ServiceWorkerCache.

Support WebServiceWorkerResponseType in ServiceWorkerCache.

BUG=418700
Committed: https://crrev.com/f04f599fc9288f7490edecaf84ca0b32dd5cc504
Cr-Commit-Position: refs/heads/master@{#297846}

[jkarlin, 2014-10-01 13:23:57]

jkarlin@chromium.org changed reviewers:
+ horo@chromium.org, jochen@chromium.org, michaeln@chromium.org,
tsepez@chromium.org

[jkarlin, 2014-10-01 13:23:58]

horo + michaeln: PTAL at everything

jochen: Please review things outside of content/browser/serviceworker for owners

tsepez: Please review service_worker_messages.h

Thanks!

[Tom Sepez, 2014-10-01 17:16:00]

Messages LGTM.

[jochen (gone - plz use gerrit), 2014-10-02 07:35:28]

lgtm with nit

https://codereview.chromium.org/617263002/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/617263002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:44:
blink::WebServiceWorkerResponseType ProtoResponseTypeToWebResponseType(
can you use the assert matching enums macro and just static_cast<> the values
back and forth?

[horo, 2014-10-02 12:28:22]

lgtm

[jkarlin, 2014-10-02 13:34:30]

https://codereview.chromium.org/617263002/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_cache.cc (right):

https://codereview.chromium.org/617263002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_cache.cc:44:
blink::WebServiceWorkerResponseType ProtoResponseTypeToWebResponseType(
On 2014/10/02 07:35:28, jochen wrote:
> can you use the assert matching enums macro and just static_cast<> the values
> back and forth?

After chat discussion with jochen@ it was clarified that since one enum is a
protobuf enum the matching enums macros is unnecessary and the cl can land as
is.

[jkarlin, 2014-10-02 13:41:41]

Waiting for a blink roll of https://codereview.chromium.org/617003003/.

[jkarlin, 2014-10-02 16:18:03]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-10-02 16:18:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617263002/80001

[commit-bot: I haz the power, 2014-10-02 16:23:34]

Committed patchset #5 (id:80001) as 0bce012426e87e01da4d67d83aa58b941e8570a4

[commit-bot: I haz the power, 2014-10-02 16:24:16]

Patchset 5 (id:??) landed as
https://crrev.com/f04f599fc9288f7490edecaf84ca0b32dd5cc504
Cr-Commit-Position: refs/heads/master@{#297846}