Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: components/signin/core/browser/signin_manager_base.h

Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager_base.h
diff --git a/components/signin/core/browser/signin_manager_base.h b/components/signin/core/browser/signin_manager_base.h
index a7a0f9b6feba6082e6fa388588334353c9698182..5ce10fa2627330af12e3998f1e298e28cfef1520 100644
--- a/components/signin/core/browser/signin_manager_base.h
+++ b/components/signin/core/browser/signin_manager_base.h
@@ -125,7 +125,7 @@ class SigninManagerBase : public KeyedService {
// Used by subclass to clear authenticated_username_ instead of using
// SetAuthenticatedUsername, which enforces special preconditions due
// to the fact that it is part of the public API and called by clients.
- void clear_authenticated_username();
+ void ClearAuthenticatedUsername();
// List of observers to notify on signin events.
// Makes sure list is empty on destruction.
@@ -146,8 +146,9 @@ class SigninManagerBase : public KeyedService {
SigninClient* client_;
bool initialized_;
- // Actual username after successful authentication.
+ // Actual username and account_id after successful authentication.
std::string authenticated_username_;
+ std::string authenticated_account_id_;
// The list of SigninDiagnosticObservers.
ObserverList<signin_internals_util::SigninDiagnosticsObserver, true>

Powered by Google App Engine
This is Rietveld 408576698