chrome/browser/ui/app_list/search/people/people_provider.cc - Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/people/people_provider.cc

Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/profiles/profile_downloader_android.cc ('K') | « chrome/browser/sync/supervised_user_signin_manager_wrapper.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/people/people_provider.cc

diff --git a/chrome/browser/ui/app_list/search/people/people_provider.cc b/chrome/browser/ui/app_list/search/people/people_provider.cc

index 97419aec50ea81891503fc6905702adf0867425e..66b3c69ba5a2a025bdf6038a86f343c954853036 100644

--- a/chrome/browser/ui/app_list/search/people/people_provider.cc

+++ b/chrome/browser/ui/app_list/search/people/people_provider.cc

@@ -118,12 +118,14 @@ void PeopleProvider::RequestAccessToken() {

if (access_token_request_ != NULL)

return;

- ProfileOAuth2TokenService* token_service =

- ProfileOAuth2TokenServiceFactory::GetForProfile(profile_);

SigninManagerBase* signin_manager =

SigninManagerFactory::GetInstance()->GetForProfile(profile_);

- access_token_request_ = token_service->StartRequest(

- signin_manager->GetAuthenticatedAccountId(), oauth2_scope_, this);

+ if (signin_manager->IsAuthenticated()) {

+ ProfileOAuth2TokenService* token_service =

+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile_);

+ access_token_request_ = token_service->StartRequest(

+ signin_manager->GetAuthenticatedAccountId(), oauth2_scope_, this);

+ }

}

GURL PeopleProvider::GetQueryUrl(const std::string& query) {