chrome/browser/signin/android_profile_oauth2_token_service.h - Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/android_profile_oauth2_token_service.h

Issue 617183003: Make sure GetAuthenticatedAccountId() returns a canonicalized id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/profiles/profile_downloader_android.cc ('K') | « chrome/browser/services/gcm/fake_signin_manager.cc ('k') | chrome/browser/signin/android_profile_oauth2_token_service.cc » ('j') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/android_profile_oauth2_token_service.h

diff --git a/chrome/browser/signin/android_profile_oauth2_token_service.h b/chrome/browser/signin/android_profile_oauth2_token_service.h

index 5f5a9a64dfc12604acf7586dce717dc13ae04d19..7f11ca74abdbc1e349e8a94188f611d3604e1521 100644

--- a/chrome/browser/signin/android_profile_oauth2_token_service.h

+++ b/chrome/browser/signin/android_profile_oauth2_token_service.h

@@ -111,6 +111,7 @@ class AndroidProfileOAuth2TokenService : public ProfileOAuth2TokenService {

// Called to notify observers when refresh tokans have been loaded.

virtual void FireRefreshTokensLoaded() OVERRIDE;

+ private:

// Return whether |signed_in_account| is valid and we have access

// to all the tokens in |curr_account_ids|. If |force_notifications| is true,

// TokenAvailable notifications will be sent anyway, even if the account was

@@ -122,7 +123,6 @@ class AndroidProfileOAuth2TokenService : public ProfileOAuth2TokenService {

std::vector<std::string>& revoked_ids,

bool force_notifications);

- private:

base::android::ScopedJavaGlobalRef<jobject> java_ref_;

static bool is_testing_profile_;