Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 617163002: Add a getSelectedText method to the PDF plugin. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
palmer, Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a getSelectedText method to the PDF plugin. Committed: https://crrev.com/7c23f3fc46a1e368780b2b6d7e0e2b183d3645d8 Cr-Commit-Position: refs/heads/master@{#297649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pdf/instance.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
Hey guys, any one of your reviews is good enough, just want someone from security ...
6 years, 2 months ago (2014-10-01 05:03:52 UTC) #2
palmer
lgtm
6 years, 2 months ago (2014-10-01 15:26:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617163002/1
6 years, 2 months ago (2014-10-01 15:30:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as fa56d22330ec92846d6d74dccb6353beb135821a
6 years, 2 months ago (2014-10-01 15:35:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c23f3fc46a1e368780b2b6d7e0e2b183d3645d8 Cr-Commit-Position: refs/heads/master@{#297649}
6 years, 2 months ago (2014-10-01 15:36:07 UTC) #7
raymes
6 years, 2 months ago (2014-10-01 17:18:15 UTC) #8
Message was sent while issue was closed.
Hey John,

What is this for? With out of process PDF, these synchronous scripting APIs will
be going away and the only way to interact will be using postMessage.
Whatever/whoever uses this will need to change their usage.

Thanks!
Raymes

Powered by Google App Engine
This is Rietveld 408576698