Update chromoting browser-tests to obtain user-name and password from a specified file.

chrome/test/remoting/remote_desktop_browsertest.h

Index: chrome/test/remoting/remote_desktop_browsertest.h
diff --git a/chrome/test/remoting/remote_desktop_browsertest.h b/chrome/test/remoting/remote_desktop_browsertest.h
index e4a025ec53d95f545635813d9c5f0ab3e7451e8d..6bdfa7ee06bb29be98511786ace49c5479e7d752 100644
--- a/chrome/test/remoting/remote_desktop_browsertest.h
+++ b/chrome/test/remoting/remote_desktop_browsertest.h
@@ -21,8 +21,10 @@ const char kNoCleanup[] = "no-cleanup";
 const char kNoInstall[] = "no-install";
 const char kWebAppCrx[] = "webapp-crx";
 const char kWebAppUnpacked[] = "webapp-unpacked";
-const char kUsername[] = "username";
-const char kkPassword[] = "password";
+const char kUserNameField[] = "username";

[weitao, 2014/10/08 23:19:16]

Isn't it called "user-name" in the json file?

[anandc, 2014/10/09 00:15:24]

It was "user_name", but I then updated it to "username" to be consistent.
Thanks.

+const char kPasswordField[] = "password";
+const char kAccountsFile[] = "accounts-file";
+const char kAccountType[] = "account-type";
 const char kMe2MePin[] = "me2me-pin";
 const char kRemoteHostName[] = "remote-host-name";
 const char kExtensionName[] = "extension-name";
@@ -125,6 +127,8 @@ class RemoteDesktopBrowserTest : public extensions::PlatformAppBrowserTest {
   void SimulateMouseClickAt(
       int modifiers, blink::WebMouseEvent::Button button, int x, int y);
 
+  bool SetUserNameAndPassword(const base::FilePath &accounts_file);
+
   // The following helpers each perform a composite task.
 
   // Install the chromoting extension
@@ -365,6 +369,8 @@ class RemoteDesktopBrowserTest : public extensions::PlatformAppBrowserTest {
   base::FilePath webapp_unpacked_;
   std::string username_;
   std::string password_;
+  std::string accounts_file_;

[weitao, 2014/10/08 23:19:16]

Why store the file path if it's not used anywhere else? But if you do want to
store it for use later I suggest that you store a scoped_ptr to the base::Value
here rather than the file path.

[anandc, 2014/10/09 00:15:24]

Done.

+  std::string account_type_;

[weitao, 2014/10/08 23:19:16]

Same as above.

[anandc, 2014/10/09 00:15:24]

Done.

   std::string me2me_pin_;
   std::string remote_host_name_;
   std::string extension_name_;