Update chromoting browser-tests to obtain user-name and password from a specified file.

chrome/test/remoting/remote_desktop_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/remoting/remote_desktop_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
@@ skipping 16 matching lines @@
 namespace remoting {
 
 RemoteDesktopBrowserTest::RemoteDesktopBrowserTest()
     : extension_(NULL) {
 }
 
 RemoteDesktopBrowserTest::~RemoteDesktopBrowserTest() {}
 
 void RemoteDesktopBrowserTest::SetUp() {
   ParseCommandLine();
+
   PlatformAppBrowserTest::SetUp();
 }
 
 void RemoteDesktopBrowserTest::SetUpOnMainThread() {
   PlatformAppBrowserTest::SetUpOnMainThread();
 
   // Pushing the initial WebContents instance onto the stack before
   // RunTestOnMainThread() and after |InProcessBrowserTest::browser_|
   // is initialized in InProcessBrowserTest::RunTestOnMainThreadLoop()
   web_contents_stack_.push_back(
@@ skipping 518 matching lines @@
   if (command_line->HasSwitch(kOverrideUserDataDir)) {
     const base::FilePath& override_user_data_dir =
         command_line->GetSwitchValuePath(kOverrideUserDataDir);
 
     ASSERT_FALSE(override_user_data_dir.empty());
 
     command_line->AppendSwitchPath(switches::kUserDataDir,
                                    override_user_data_dir);
   }
 
-  username_ = command_line->GetSwitchValueASCII(kUsername);
-  password_ = command_line->GetSwitchValueASCII(kkPassword);
+  accounts_file_ = command_line->GetSwitchValueASCII(kAccountsFile);
+  account_type_ = command_line->GetSwitchValueASCII(kAccountType);
+  if (!accounts_file_.empty()) {
+    // We've been passed in a file containing accounts information.
+    // In this case, we'll obtain the user-name and password information from
+    // the specified file, even if user-name and password have been specified
+    // on the command-line.
+    base::FilePath accounts_file_path(accounts_file_);
+    ASSERT_FALSE(account_type_.empty());
+    ASSERT_TRUE(base::PathExists(accounts_file_path));
+    SetUserNameAndPassword(accounts_file_path);
+  } else {
+    // No file for accounts specified. Read user-name and password from command
+    // line.
+    username_ = command_line->GetSwitchValueASCII(kUserName);
+    password_ = command_line->GetSwitchValueASCII(kPassword);
+  }
+
   me2me_pin_ = command_line->GetSwitchValueASCII(kMe2MePin);
   remote_host_name_ = command_line->GetSwitchValueASCII(kRemoteHostName);
   extension_name_ = command_line->GetSwitchValueASCII(kExtensionName);
   http_server_ = command_line->GetSwitchValueASCII(kHttpServer);
 
   no_cleanup_ = command_line->HasSwitch(kNoCleanup);
   no_install_ = command_line->HasSwitch(kNoInstall);
 
   if (!no_install_) {
     webapp_crx_ = command_line->GetSwitchValuePath(kWebAppCrx);
@@ skipping 204 matching lines @@
 bool RemoteDesktopBrowserTest::IsPinFormVisible() {
   DismissHostVersionWarningIfVisible();
   return HtmlElementVisible("pin-form");
 }
 
 void RemoteDesktopBrowserTest::DismissHostVersionWarningIfVisible() {
   if (HtmlElementVisible("host-needs-update-connect-button"))
     ClickOnControl("host-needs-update-connect-button");
 }
 
+void RemoteDesktopBrowserTest::SetUserNameAndPassword(

[weitao, 2014/10/08 23:19:16]

I suggest that we don't store the accounts file path and account type as member
variables. Rather just pass them in to SetUserNameAndPassword.

[anandc, 2014/10/09 00:15:25]

Done.

+    const base::FilePath &accounts_file_path) {
+
+  // Read contents of accounts file.
+  std::string accounts_info;
+  ASSERT_TRUE(base::ReadFileToString(accounts_file_path, &accounts_info));
+
+  scoped_ptr<base::Value> root(
+      base::JSONReader::Read(accounts_info, base::JSON_ALLOW_TRAILING_COMMAS));
+  DCHECK(root.get() != NULL);
+  ASSERT_TRUE(root.get() && root->GetType() == base::Value::TYPE_DICTIONARY);
+
+  // Get the root dictionary from the input json file contents.
+  const base::DictionaryValue* root_dict =
+      static_cast<base::DictionaryValue*>(root.get());

[weitao, 2014/10/08 23:19:16]

Please use GetAsDictionary. And instead of asserting the type is dictionary
above, you can just assert the return result of GetAsDictionary.

[anandc, 2014/10/09 00:15:25]

Done.

+  // And now the dictionary for the specified account type.
+  const base::DictionaryValue* account_dict = NULL;
+  root_dict->GetDictionary(account_type_, &account_dict);

[weitao, 2014/10/08 23:19:16]

assert the result of GetDictionary.

[anandc, 2014/10/09 00:15:24]

Done.

+
+  ASSERT_TRUE(account_dict->GetString(kUserName, &username_));
+
+  ASSERT_TRUE(account_dict->GetString(kPassword, &password_));
+}
+
 // static
 bool RemoteDesktopBrowserTest::IsAuthenticatedInWindow(
     content::WebContents* web_contents) {
   return ExecuteScriptAndExtractBool(
       web_contents, "remoting.identity.isAuthenticated()");
 }
 
 // static
 bool RemoteDesktopBrowserTest::IsHostActionComplete(
     content::WebContents* client_web_content,
     std::string host_action_var) {
   return ExecuteScriptAndExtractBool(
       client_web_content,
       host_action_var);
 }
 
 // static
 bool RemoteDesktopBrowserTest::IsEnabled(
     content::WebContents* client_web_content,
     const std::string& element_name) {
   return !ExecuteScriptAndExtractBool(
     client_web_content,
     "document.getElementById(\"" + element_name + "\").disabled");
 }
 
 }  // namespace remoting