Source/platform/fonts/GlyphPageTreeNode.cpp - Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/GlyphPageTreeNode.cpp

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical

Patch Set: Additional TestExpectations tweaking for Mac Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/GlyphPageTreeNode.cpp

diff --git a/Source/platform/fonts/GlyphPageTreeNode.cpp b/Source/platform/fonts/GlyphPageTreeNode.cpp

index 0022c334ed57c0440a38b5685133e05ed6152676..892cc69d861f395cf7872f2d01c70a4210db8dc0 100644

--- a/Source/platform/fonts/GlyphPageTreeNode.cpp

+++ b/Source/platform/fonts/GlyphPageTreeNode.cpp

@@ -121,10 +121,6 @@ void GlyphPageTreeNode::pruneTreeFontData(const SimpleFontData* fontData)

static bool fill(GlyphPage* pageToFill, unsigned offset, unsigned length, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)

{

bool hasGlyphs = fontData->fillGlyphPage(pageToFill, offset, length, buffer, bufferLength);

-#if ENABLE(OPENTYPE_VERTICAL)

- if (hasGlyphs && fontData->verticalData())

- fontData->verticalData()->substituteWithVerticalGlyphs(fontData, pageToFill, offset, length);

-#endif

return hasGlyphs;

}

« no previous file with comments | « Source/platform/fonts/FontPlatformData.cpp ('k') | Source/platform/fonts/SimpleFontData.h » ('j') | no next file with comments »