Source/platform/fonts/FontFaceCreationParams.h - Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/FontFaceCreationParams.h

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical

Patch Set: Additional TestExpectations tweaking for Mac Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/FontFaceCreationParams.h

diff --git a/Source/platform/fonts/FontFaceCreationParams.h b/Source/platform/fonts/FontFaceCreationParams.h

index 26675a14c6727d746a4ad329948c1034bb028529..9736352ff11b77063eebac08fdbce3d1e8bcdd4e 100644

--- a/Source/platform/fonts/FontFaceCreationParams.h

+++ b/Source/platform/fonts/FontFaceCreationParams.h

@@ -59,7 +59,7 @@ public:

explicit FontFaceCreationParams(AtomicString family)

: m_creationType(CreateFontByFamily), m_family(family), m_filename(CString()), m_fontconfigInterfaceId(0), m_ttcIndex(0)

{

-#if OS(WIN) && ENABLE(OPENTYPE_VERTICAL)

+#if OS(WIN)

// Leading "@" in the font name enables Windows vertical flow flag for the font.

// Because we do vertical flow by ourselves, we don't want to use the Windows feature.

// IE disregards "@" regardless of the orientation, so we follow the behavior and

« no previous file with comments | « Source/platform/fonts/FontDataCache.cpp ('k') | Source/platform/fonts/FontPlatformData.h » ('j') | no next file with comments »