Source/platform/fonts/mac/FontPlatformDataMac.mm - Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/FontPlatformDataMac.mm

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical

Patch Set: Adding a Mac rebaseline Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/mac/FontPlatformDataMac.mm

diff --git a/Source/platform/fonts/mac/FontPlatformDataMac.mm b/Source/platform/fonts/mac/FontPlatformDataMac.mm

index 6a5da23dd7d1eaf84777db8d5f1d406284c21570..4a0fc8d3b73e7f40caef2b3bd0852f05dfd618df 100644

--- a/Source/platform/fonts/mac/FontPlatformDataMac.mm

+++ b/Source/platform/fonts/mac/FontPlatformDataMac.mm

@@ -38,13 +38,6 @@

namespace blink {

-unsigned FontPlatformData::hash() const

- ASSERT(m_font || !m_cgFont);

- uintptr_t hashCodes[2] = { (uintptr_t)m_font, static_cast<uintptr_t>(m_isHashTableDeletedValue << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticItalic) };

- return StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes);

void FontPlatformData::setupPaint(SkPaint* paint, GraphicsContext*, const Font* font) const

{

bool shouldSmoothFonts = true;

« Source/platform/fonts/Font.cpp ('K') | « Source/platform/fonts/SimpleFontData.cpp ('k') | Source/platform/fonts/opentype/OpenTypeVerticalData.h » ('j') | no next file with comments »