Source/platform/fonts/skia/FontPlatformDataSkia.cpp - Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/skia/FontPlatformDataSkia.cpp

Issue 617103003: Replace ENABLE_OPENTYPE_VERTICAL implementation with HarfBuzz (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@removeOpenTypeVertical

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp ('K') | « Source/platform/fonts/opentype/OpenTypeVerticalData.cpp ('k') | Source/web/tests/OpenTypeVerticalDataTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/skia/FontPlatformDataSkia.cpp

diff --git a/Source/platform/fonts/skia/FontPlatformDataSkia.cpp b/Source/platform/fonts/skia/FontPlatformDataSkia.cpp

index 3f51a0b6c6c6157474587c04f059b5cd9c679fdb..152905169abcab3eff3c9556723363de1e69cccf 100644

--- a/Source/platform/fonts/skia/FontPlatformDataSkia.cpp

+++ b/Source/platform/fonts/skia/FontPlatformDataSkia.cpp

@@ -66,7 +66,6 @@ bool FontPlatformData::fontContainsCharacter(UChar32 character)

#endif

-#if ENABLE(OPENTYPE_VERTICAL)

PassRefPtr<OpenTypeVerticalData> FontPlatformData::verticalData() const

{

return FontCache::fontCache()->getVerticalData(typeface()->uniqueID(), *this);

@@ -85,6 +84,5 @@ PassRefPtr<SharedBuffer> FontPlatformData::openTypeTable(uint32_t table) const

}

return buffer.release();

}

-#endif

} // namespace blink