Remove globals from tests/CanvasTest.cpp

Remove globals from tests/CanvasTest.cpp

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/f05f5a7399b7d748403b234d1faced9f4c61891f

[Rémi Piotaix, 2014-10-01 21:55:49]

piotaixr@chromium.org changed reviewers:
+ junov@chromium.org, reed@google.com

[Rémi Piotaix, 2014-10-01 21:55:57]

PTAL

[reed1, 2014-10-02 19:53:06]

wow, nice refactoring.

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp
File tests/CanvasTest.cpp (right):

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode151
tests/CanvasTest.cpp:151: static SkPath test_nearly_zero_length_path() {
nit: Static methods are Capitalized

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode163
tests/CanvasTest.cpp:163: static SkRegion testRegion() {
same static function nit

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode878
tests/CanvasTest.cpp:878: //    kTestBitmap = testBitmap();
can we remove this // line?

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode889
tests/CanvasTest.cpp:889: //    kTestBitmap.reset();
can we remove this reset()?

[Rémi Piotaix, 2014-10-02 20:02:26]

Maybe rename the variable named "testData" to "d", this way it is maybe less
verbose to create tests using SIMPLE_TEST_STEP ?

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp
File tests/CanvasTest.cpp (right):

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode151
tests/CanvasTest.cpp:151: static SkPath test_nearly_zero_length_path() {
On 2014/10/02 19:53:06, reed1 wrote:
> nit: Static methods are Capitalized

Done.

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode163
tests/CanvasTest.cpp:163: static SkRegion testRegion() {
On 2014/10/02 19:53:06, reed1 wrote:
> same static function nit

Done.

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode878
tests/CanvasTest.cpp:878: //    kTestBitmap = testBitmap();
On 2014/10/02 19:53:06, reed1 wrote:
> can we remove this // line?

Done.

https://codereview.chromium.org/617093004/diff/1/tests/CanvasTest.cpp#newcode889
tests/CanvasTest.cpp:889: //    kTestBitmap.reset();
On 2014/10/02 19:53:06, reed1 wrote:
> can we remove this reset()?

Done.

[Rémi Piotaix, 2014-10-03 19:27:28]

New patch

[reed1, 2014-10-03 20:13:07]

lgtm

[Rémi Piotaix, 2014-10-03 20:17:50]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-10-03 20:18:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617093004/60001

[commit-bot: I haz the power, 2014-10-03 20:26:59]

Committed patchset #4 (id:60001) as f05f5a7399b7d748403b234d1faced9f4c61891f