Plugin Power Saver: Add flag to experiment behind.

Plugin Power Saver: Add flag to experiment behind.

This adds a flag we can experiment behind and begin the implementation parts we know how to do.

Design doc: http://goo.gl/iDix3p

BUG=403800
Committed: https://crrev.com/3c366b33751752790db5a550ad26adaf9d46d313
Cr-Commit-Position: refs/heads/master@{#298304}

[tommycli, 2014-09-30 22:24:12]

tommycli@chromium.org changed reviewers:
+ laforge@chromium.org

[tommycli, 2014-09-30 22:24:13]

laforge: Let me know if the messaging in generated_resources.grd is appropriate.

[laforge, 2014-09-30 22:52:01]

laforge@google.com changed reviewers:
+ laforge@google.com

[laforge, 2014-09-30 22:52:02]

https://codereview.chromium.org/617073002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/617073002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6086: +        Enables experimental power
saver mode for non-essential plugin content.
perhaps change "non-essential" to "peripheral" (to avoid calling ads
non-essential, even indirectly)

[tommycli, 2014-10-01 16:19:52]

tommycli@chromium.org changed reviewers:
+ jochen@chromium.org
- laforge@google.com

[tommycli, 2014-10-01 16:19:54]

jochen: May I have a content/ review to enable a new flag? Let me know if
there's a better reviewer for Plugin Power Saver stuff.

laforge: Done

https://codereview.chromium.org/617073002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/617073002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6086: +        Enables experimental power
saver mode for non-essential plugin content.
On 2014/09/30 22:52:01, laforge wrote:
> perhaps change "non-essential" to "peripheral" (to avoid calling ads
> non-essential, even indirectly)

Done.

[jochen (gone - plz use gerrit), 2014-10-02 07:34:10]

i'd expect you need to change histograms.xml as well

my parts lgtm

[tommycli, 2014-10-02 19:31:36]

jochen: Thank you! i added an entry to histograms.xml

[tommycli, 2014-10-02 20:04:35]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-10-02 20:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617073002/40001

[commit-bot: I haz the power, 2014-10-02 20:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-02 20:15:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2014-10-02 20:26:02]

tommycli@chromium.org changed reviewers:
+ mpearson@chromium.org

[tommycli, 2014-10-02 20:26:03]

mpearson: May I have a review on histograms.xml?

[raymes, 2014-10-03 15:29:24]

raymes@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2014-10-03 22:33:54]

lgtm

[tommycli, 2014-10-06 16:52:47]

mpearson: ping

[groby-ooo-7-16, 2014-10-06 17:24:42]

Drive-by comment :)

https://codereview.chromium.org/617073002/diff/40001/chrome/browser/about_fla...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/617073002/diff/40001/chrome/browser/about_fla...
chrome/browser/about_flags.cc:1945: #if defined(ENABLE_PLUGINS)
Question: Do we want to have this in about:flags? I'd rather keep it
command-line only, for now.

[laforge, 2014-10-06 17:57:03]

On 2014/10/06 17:24:42, groby wrote:
> Drive-by comment :)
> 
>
https://codereview.chromium.org/617073002/diff/40001/chrome/browser/about_fla...
> File chrome/browser/about_flags.cc (right):
> 
>
https://codereview.chromium.org/617073002/diff/40001/chrome/browser/about_fla...
> chrome/browser/about_flags.cc:1945: #if defined(ENABLE_PLUGINS)
> Question: Do we want to have this in about:flags? I'd rather keep it
> command-line only, for now.

Flags are a little harder to set on non-windows platforms, so I'd personally
vote in favor of keeping the chrome://flags... since it makes it easier to play
w/ across a number of devices.

In general, it's fine if people see this feature in about:flags, since we
already support click-to-play it's effectively a WIP variant of that feature.

[Mark P, 2014-10-06 18:50:15]

histograms.xml rubberstamp lgtm
(not sure how I missed this notification originally)

[tommycli, 2014-10-06 19:07:49]

On 2014/10/06 17:57:03, laforge wrote:
> On 2014/10/06 17:24:42, groby wrote:
> > Drive-by comment :)
> > 
> >
>
https://codereview.chromium.org/617073002/diff/40001/chrome/browser/about_fla...
> > File chrome/browser/about_flags.cc (right):
> > 
> >
>
https://codereview.chromium.org/617073002/diff/40001/chrome/browser/about_fla...
> > chrome/browser/about_flags.cc:1945: #if defined(ENABLE_PLUGINS)
> > Question: Do we want to have this in about:flags? I'd rather keep it
> > command-line only, for now.
> 
> Flags are a little harder to set on non-windows platforms, so I'd personally
> vote in favor of keeping the chrome://flags... since it makes it easier to
play
> w/ across a number of devices.
> 
> In general, it's fine if people see this feature in about:flags, since we
> already support click-to-play it's effectively a WIP variant of that feature.

I'd also be in favor of keeping it in about:flags. If this is okay with you,
groby, I can check CQ and proceed?

[tommycli, 2014-10-06 20:18:27]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-10-06 20:22:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617073002/40001

[commit-bot: I haz the power, 2014-10-06 23:06:02]

Committed patchset #3 (id:40001) as 798def40a490a96614fde521a440e2c25813c571

[commit-bot: I haz the power, 2014-10-06 23:07:00]

Patchset 3 (id:??) landed as
https://crrev.com/3c366b33751752790db5a550ad26adaf9d46d313
Cr-Commit-Position: refs/heads/master@{#298304}