Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 617053002: Fix crash in ChromeExtensionMessageFilter::OnPostMessage (Closed)

Created:
6 years, 2 months ago by James Cook
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash in ChromeExtensionMessageFilter::OnPostMessage Speculative fix: ChromeExtensionMessageFilter can outlive its Profile, so check |profile_| for NULL in OnPostMessage as is done in other message handlers. BUG=419047 TEST=none Committed: https://crrev.com/a3e007d47ef0ca2d089510a64f4760a0f8bfeadd Cr-Commit-Position: refs/heads/master@{#297531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
James Cook
rockot, since kalman is out, can you take a look?
6 years, 2 months ago (2014-09-30 20:34:09 UTC) #2
Ken Rockot(use gerrit already)
Seems right to me. Thanks and lgtm
6 years, 2 months ago (2014-09-30 20:38:19 UTC) #3
James Cook
sky, can I get OWNERS? If looks good without nits feel free to CQ.
6 years, 2 months ago (2014-09-30 20:48:19 UTC) #7
sky
LGTM
6 years, 2 months ago (2014-09-30 21:44:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617053002/1
6 years, 2 months ago (2014-09-30 22:14:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9b02d5fadb92b8f8c76f6e002809b1b2806b365a
6 years, 2 months ago (2014-09-30 22:37:26 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:38:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3e007d47ef0ca2d089510a64f4760a0f8bfeadd
Cr-Commit-Position: refs/heads/master@{#297531}

Powered by Google App Engine
This is Rietveld 408576698