Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/telemetry/telemetry/core/wpr_server.py

Issue 617043003: Handle replay args within replay module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@combinewpr-localremote-ports
Patch Set: Rebase. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/webpagereplay_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/wpr_server.py
diff --git a/tools/telemetry/telemetry/core/wpr_server.py b/tools/telemetry/telemetry/core/wpr_server.py
index be377ab5853db316c9ca6a5b825bbec725f3333b..08f8bad02b4110f77ffbc9afe399259bc7306539 100644
--- a/tools/telemetry/telemetry/core/wpr_server.py
+++ b/tools/telemetry/telemetry/core/wpr_server.py
@@ -19,6 +19,8 @@ class ReplayServer(object):
self._web_page_replay = None
wpr_args = browser_backend.browser_options.extra_wpr_args
+ if browser_backend.browser_options.netsim:
+ wpr_args.append('--net=%s' % browser_backend.browser_options.netsim)
if wpr_mode == wpr_modes.WPR_APPEND:
wpr_args.append('--append')
elif wpr_mode == wpr_modes.WPR_RECORD:
@@ -30,8 +32,6 @@ class ReplayServer(object):
'--should_generate_certs',
'--https_root_ca_cert_path=%s' % browser_backend.wpr_ca_cert_path,
])
- browser_backend.AddReplayServerOptions(wpr_args)
-
self._web_page_replay = webpagereplay.ReplayServer(
path, self._browser_backend.forwarder_factory.host_ip,
browser_backend.wpr_port_pairs.http.local_port,
@@ -39,9 +39,6 @@ class ReplayServer(object):
(browser_backend.wpr_port_pairs.dns.local_port
if browser_backend.wpr_port_pairs.dns else None),
wpr_args)
- # Remove --no-dns_forwarding if it wasn't explicitly requested by backend.
- if '--no-dns_forwarding' not in wpr_args:
- self._web_page_replay.replay_options.remove('--no-dns_forwarding')
started_ports = self._web_page_replay.StartServer()
# Assign the forwarder port pairs back to the browser_backend.
« no previous file with comments | « tools/telemetry/telemetry/core/webpagereplay_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698