Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 617043002: Moving athena/test to athena/test/base (Closed)

Created:
6 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moving athena/test to athena/test/base BUG=412474 TEST=none Committed: https://crrev.com/9f98c0f43025605a15114b4b42c7b1319b72d771 Cr-Commit-Position: refs/heads/master@{#297527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -838 lines) Patch
M athena/activity/activity_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/athena.gyp View 2 chunks +12 lines, -12 lines 0 comments Download
M athena/content/app_activity_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/env/athena_env_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/athena_start_page_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/home_card_gesture_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/home_card_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/input/accelerator_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/resource_manager/memory_pressure_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/resource_manager/resource_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/screen/screen_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D athena/test/athena_test_base.h View 1 chunk +0 lines, -53 lines 0 comments Download
D athena/test/athena_test_base.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D athena/test/athena_test_helper.h View 1 chunk +0 lines, -74 lines 0 comments Download
D athena/test/athena_test_helper.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D athena/test/athena_unittests.cc View 1 chunk +0 lines, -55 lines 0 comments Download
A + athena/test/base/athena_test_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + athena/test/base/athena_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + athena/test/base/athena_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/test/base/athena_test_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + athena/test/base/athena_unittests.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/test/base/sample_activity.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/test/base/sample_activity.cc View 1 chunk +1 line, -1 line 0 comments Download
A + athena/test/base/sample_activity_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/test/base/sample_activity_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + athena/test/base/test_app_model_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/test/base/test_app_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + athena/test/base/test_resource_manager_delegate.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D athena/test/sample_activity.h View 1 chunk +0 lines, -62 lines 0 comments Download
D athena/test/sample_activity.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D athena/test/sample_activity_factory.h View 1 chunk +0 lines, -33 lines 0 comments Download
D athena/test/sample_activity_factory.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D athena/test/test_app_model_builder.h View 1 chunk +0 lines, -27 lines 0 comments Download
D athena/test/test_app_model_builder.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D athena/test/test_resource_manager_delegate.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M athena/wm/split_view_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_list_provider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mr4D (OOO till 08-26)
As moved from other patch here: Moved the athena/test files to athena/test/base. Please have a ...
6 years, 2 months ago (2014-09-30 20:05:39 UTC) #2
oshima
lgtm
6 years, 2 months ago (2014-09-30 20:57:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617043002/1
6 years, 2 months ago (2014-09-30 21:25:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e1e57229e03b793287288a5583c6c0649c8b1885
6 years, 2 months ago (2014-09-30 22:21:07 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:21:49 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f98c0f43025605a15114b4b42c7b1319b72d771
Cr-Commit-Position: refs/heads/master@{#297527}

Powered by Google App Engine
This is Rietveld 408576698