Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 617023005: Tweak the highlight color for extensions in the extension list (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Tweak the highlight color for extensions in the extension list Change from 238, 238, 238 to 250, 250, 250 (#FAFAFA). before and after: http://imgur.com/rAotOUN,rEUR68f BUG=419202 Committed: https://crrev.com/66632414efeb46688b551a705d5147f0bad7f6d5 Cr-Commit-Position: refs/heads/master@{#297887}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 1 chunk +1 line, -3 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Devlin
Dan, please take a look. I'd also like your opinion on whether or not this ...
6 years, 2 months ago (2014-10-01 00:40:00 UTC) #2
Devlin
On 2014/10/01 00:40:00, Devlin wrote: > Dan, please take a look. I'd also like your ...
6 years, 2 months ago (2014-10-02 17:05:26 UTC) #3
Dan Beam
lgtm from a colorblind person https://codereview.chromium.org/617023005/diff/1/chrome/browser/resources/extensions/extensions.css File chrome/browser/resources/extensions/extensions.css (left): https://codereview.chromium.org/617023005/diff/1/chrome/browser/resources/extensions/extensions.css#oldcode392 chrome/browser/resources/extensions/extensions.css:392: background-position: auto; On 2014/10/01 ...
6 years, 2 months ago (2014-10-02 18:49:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617023005/1
6 years, 2 months ago (2014-10-02 19:28:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1a9137ab2eb1b9d6a1e0de795d06363b2587c1c6
6 years, 2 months ago (2014-10-02 20:24:27 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:25:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66632414efeb46688b551a705d5147f0bad7f6d5
Cr-Commit-Position: refs/heads/master@{#297887}

Powered by Google App Engine
This is Rietveld 408576698