ui/keyboard/keyboard_controller.cc - Issue 617013002: Remove redundant SetBounds calls to the keyboard window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 617013002: Remove redundant SetBounds calls to the keyboard window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/keyboard/keyboard_controller.cc

diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc

index 1b7b9f3a8e5cba1d9b627117dc4899bbeda773e2..8e9fd20af1105edb263c8b7b517924ee7375a0cd 100644

--- a/ui/keyboard/keyboard_controller.cc

+++ b/ui/keyboard/keyboard_controller.cc

@@ -43,8 +43,9 @@ const int kShowAnimationDurationMs = 350;

const int kHideAnimationDurationMs = 100;

// The opacity of virtual keyboard container when show animation starts or

-// hide animation finishes.

-// TODO(rsadam@): Investigate why setting this to zero crashes.

+// hide animation finishes. This cannot be zero because we call Show() on the

+// keyboard window before setting the opacity back to 1.0. Since windows are not

+// allowed to be shown with zero opacity, we always animate to 0.01 instead.

const float kAnimationStartOrAfterHideOpacity = 0.01f;

// Event targeter for the keyboard container.

« no previous file with comments | « no previous file | ui/keyboard/keyboard_controller_proxy.cc » ('j') | no next file with comments »