Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 617003006: Credential Manager: Expose the runtime flag to the embedder. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, jamesr, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Credential Manager: Expose the runtime flag to the embedder. The credential manager's current implementation exposes sensitive information to websites via a JavaScript API. Until we have a good feel for exactly what we want to expose, how we want to expose it, and what UI needs to be tied to that exposure, we shouldn't enable this via the general "Experimental Web Features" flag. We do want to enable testing, though: creating a separate flag on about:flags seems like a reasonable way of containing the risk. BUG=400674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
WDYT, friendly public/ OWNER? -mike
6 years, 2 months ago (2014-10-01 12:33:51 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-01 14:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617003006/1
6 years, 2 months ago (2014-10-01 14:06:19 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 15:28:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183065

Powered by Google App Engine
This is Rietveld 408576698