Source/modules/serviceworkers/CacheTest.cpp - Issue 617003003: Make WebServiceWorkerResponse support ResponseType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/CacheTest.cpp

Issue 617003003: Make WebServiceWorkerResponse support ResponseType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addresses comments from PS4 and fixes some cache tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/serviceworkers/FetchResponseData.cpp » ('j') | Source/modules/serviceworkers/FetchResponseData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/CacheTest.cpp

diff --git a/Source/modules/serviceworkers/CacheTest.cpp b/Source/modules/serviceworkers/CacheTest.cpp

index 1a4c236f17c9d1cefa7501186764a7df0163198f..b90dc54385b7efe8035b70d4d74d638d55734921 100644

--- a/Source/modules/serviceworkers/CacheTest.cpp

+++ b/Source/modules/serviceworkers/CacheTest.cpp

@@ -424,6 +424,7 @@ TEST_F(ServiceWorkerCacheTest, MatchResponseTest)

WebServiceWorkerResponse webResponse;

webResponse.setURL(KURL(ParsedURLString, responseUrl));

+ webResponse.setResponseType(WebServiceWorkerResponse::DefaultType);

Cache* cache = Cache::create(new MatchTestCache(webResponse));

CacheQueryOptions* options = CacheQueryOptions::create();

@@ -511,7 +512,9 @@ TEST_F(ServiceWorkerCacheTest, MatchAllAndBatchResponseTest)

WebVector<WebServiceWorkerResponse> webResponses(size_t(2));

webResponses[0].setURL(KURL(ParsedURLString, url1));

+ webResponses[0].setResponseType(WebServiceWorkerResponse::DefaultType);

webResponses[1].setURL(KURL(ParsedURLString, url2));

+ webResponses[1].setResponseType(WebServiceWorkerResponse::DefaultType);

Cache* cache = Cache::create(new MatchAllAndBatchTestCache(webResponses));

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/serviceworkers/FetchResponseData.cpp » ('j') | Source/modules/serviceworkers/FetchResponseData.cpp » ('J')