Issue 6170008: Fix CalculateEmitStore HashMap use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6170008: Fix CalculateEmitStore HashMap use. (Closed)

Created:
9 years, 11 months ago by Martin Maly

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix CalculateEmitStore HashMap use. The hash maps are setup to store strings or smis but instead Literal is being in them. It seems to only work by accident. Came across this while implementing ES5 strict mode. Ran tests (ia32, arm simulator and x64) and presubmit.py. BUG= TEST= Comitted as bleeding edge revision 6279.

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/ast.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, good catch. :)

Expand Messages | Collapse Messages