Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 616953003: Remove keyNeeded() now that encrypted() exists. (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
CC:
blink-reviews, jamesr, philipj_slow, eric.carlson_apple.com, mkwst+moarreviews_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@onencrypted
Project:
blink
Visibility:
Public.

Description

Remove keyNeeded() now that encrypted() exists. BUG=224786 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184008

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add WebMediaPlayerClientImpl.cpp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/web/WebMediaPlayerClientImpl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/WebMediaPlayerClient.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-10-17 20:35:12 UTC) #2
Mike West
LGTM. Removing code is wonderful.
6 years, 2 months ago (2014-10-18 09:08:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616953003/20001
6 years, 2 months ago (2014-10-20 17:46:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/30014)
6 years, 2 months ago (2014-10-20 18:11:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616953003/40001
6 years, 2 months ago (2014-10-20 18:31:26 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:15:03 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 184008

Powered by Google App Engine
This is Rietveld 408576698