Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 616933003: Add error handler for license request. (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fail tests if the license request XHR fails due to a network error. Committed: https://crrev.com/a99358ea74e7036e56a3285872f4b2fe718fc36d Cr-Commit-Position: refs/heads/master@{#297509}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also log statusText. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M media/test/data/eme_player_js/utils.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-09-30 20:20:06 UTC) #2
ddorwin
https://codereview.chromium.org/616933003/diff/1/media/test/data/eme_player_js/utils.js File media/test/data/eme_player_js/utils.js (right): https://codereview.chromium.org/616933003/diff/1/media/test/data/eme_player_js/utils.js#newcode230 media/test/data/eme_player_js/utils.js:230: Utils.failTest('FAILED: Unable to request license.'); How about: 'FAILED: License ...
6 years, 2 months ago (2014-09-30 20:43:44 UTC) #3
sandersd (OOO until July 31)
https://codereview.chromium.org/616933003/diff/1/media/test/data/eme_player_js/utils.js File media/test/data/eme_player_js/utils.js (right): https://codereview.chromium.org/616933003/diff/1/media/test/data/eme_player_js/utils.js#newcode230 media/test/data/eme_player_js/utils.js:230: Utils.failTest('FAILED: Unable to request license.'); On 2014/09/30 20:43:44, ddorwin ...
6 years, 2 months ago (2014-09-30 20:56:35 UTC) #4
ddorwin
lgtm
6 years, 2 months ago (2014-09-30 21:07:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616933003/20001
6 years, 2 months ago (2014-09-30 21:09:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 74f030a29ab769a6da87b377fb49fc0072818833
6 years, 2 months ago (2014-09-30 21:46:00 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:46:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a99358ea74e7036e56a3285872f4b2fe718fc36d
Cr-Commit-Position: refs/heads/master@{#297509}

Powered by Google App Engine
This is Rietveld 408576698