Use UnboxedInt32 and UnboxedUint32 representation for LoadIndexedInstr

runtime/vm/assembler_x64_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 2421 matching lines @@
 
 
 ASSEMBLER_TEST_RUN(DoubleFPOperations, test) {
   typedef double (*SingleFPOperationsCode)();
   double res = reinterpret_cast<SingleFPOperationsCode>(test->entry())();
   EXPECT_FLOAT_EQ(7.668, res, 0.001);
 }
 
 
 ASSEMBLER_TEST_GENERATE(Int32ToDoubleConversion, assembler) {
-  __ movl(RDX, Immediate(6));
-  __ cvtsi2sd(XMM0, RDX);
-  __ movl(RDX, Immediate(8));
-  __ cvtsi2sd(XMM8, RDX);
+  // Fill upper bits with garbage.
+  __ movq(RDX, Immediate(0x1111111100000006));
+  __ cvtsi2sd32(XMM0, RDX);
+  // Fill upper bits with garbage.
+  __ movq(RDX, Immediate(0x2222222200000008));

[Vyacheslav Egorov (Google), 2014/10/09 19:08:58]

maybe use another x64 register instead of RDX (e.g. R11 etc) 

[Cutch, 2014/10/09 20:48:22]

Done.

+  __ cvtsi2sd32(XMM8, RDX);
   __ subsd(XMM0, XMM8);
   __ ret();
 }
 
 
 ASSEMBLER_TEST_RUN(Int32ToDoubleConversion, test) {
-  typedef double (*IntToDoubleConversionCode)();
-  double res = reinterpret_cast<IntToDoubleConversionCode>(test->entry())();
+  typedef double (*Int32ToDoubleConversion)();
+  double res = reinterpret_cast<Int32ToDoubleConversion>(test->entry())();
   EXPECT_FLOAT_EQ(-2.0, res, 0.001);
 }
 
 
 ASSEMBLER_TEST_GENERATE(Int64ToDoubleConversion, assembler) {
   __ movq(RDX, Immediate(12LL << 32));
   __ cvtsi2sd(XMM0, RDX);
   __ movsd(XMM15, XMM0);  // Move to high register
   __ addsd(XMM0, XMM0);  // Stomp XMM0
   __ movsd(XMM0, XMM15);  // Move back to XMM0
@@ skipping 560 matching lines @@
   int res = reinterpret_cast<ConditionalMovesNoOverflowCode>(
       test->entry())(0x7fffffffffffffff, 2);
   EXPECT_EQ(1, res);
   res = reinterpret_cast<ConditionalMovesNoOverflowCode>(test->entry())(1, 1);
   EXPECT_EQ(0, res);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64