Use UnboxedInt32 and UnboxedUint32 representation for LoadIndexedInstr

runtime/vm/disassembler_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM64.
 #if defined(TARGET_ARCH_ARM64)
 #include "platform/assert.h"
 
@@ skipping 1183 matching lines @@
     // Double.
     Format(instr, "fmovd 'vd, 'immd");
   } else {
     // Single.
     Unknown(instr);
   }
 }
 
 
 void ARM64Decoder::DecodeFPIntCvt(Instr* instr) {
-  if ((instr->SFField() != 1) || (instr->Bit(29) != 0) ||
-      (instr->Bits(22, 2) != 1)) {
+  if ((instr->Bit(29) != 0) || (instr->Bits(22, 2) != 1)) {
     Unknown(instr);
     return;
   }
+  if (instr->SFField() == 0) {

[zra, 2014/10/09 18:00:30]

Remove this if() {} and just use the format string below.

[Cutch, 2014/10/09 18:49:11]

Done.

+    if (instr->Bits(16, 5) == 2) {
+      Format(instr, "scvtfd 'vd, 'vn");
+    } else {
+      Unknown(instr);
+    }
+    return;
+  }
   if (instr->Bits(16, 5) == 2) {
     Format(instr, "scvtfd 'vd, 'vn");

[zra, 2014/10/09 18:00:30]

"scvtfd'sf 'vd, 'rn"

[Cutch, 2014/10/09 18:49:11]

Done.

   } else if (instr->Bits(16, 5) == 6) {
     Format(instr, "fmovrd 'rd, 'vn");
   } else if (instr->Bits(16, 5) == 7) {
     Format(instr, "fmovdr 'vd, 'rn");
   } else if (instr->Bits(16, 5) == 24) {
     Format(instr, "fcvtzds 'rd, 'vn");
   } else {
     Unknown(instr);
   }
 }
@@ skipping 165 matching lines @@
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM