Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: content/browser/renderer_host/media/video_capture_manager.h

Issue 616833004: chrome://media-internals: update MediaInternals when devices capabilities are enumerated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: FakeVCDFactory needs to specify capture API for Win. Linux/CrOs MediaInternalsVideoCaptureDeviceTes… Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_manager.h
diff --git a/content/browser/renderer_host/media/video_capture_manager.h b/content/browser/renderer_host/media/video_capture_manager.h
index b2b6360513489e031909a9043e638962e4777a8a..1914f97b48b737d775be31275f74f0bc67f4b268 100644
--- a/content/browser/renderer_host/media/video_capture_manager.h
+++ b/content/browser/renderer_host/media/video_capture_manager.h
@@ -27,6 +27,7 @@
#include "content/common/media/media_stream_options.h"
#include "media/video/capture/video_capture_device.h"
#include "media/video/capture/video_capture_device_factory.h"
+#include "media/video/capture/video_capture_device_info.h"
#include "media/video/capture/video_capture_types.h"
namespace content {
@@ -134,19 +135,6 @@ class CONTENT_EXPORT VideoCaptureManager : public MediaStreamProvider {
virtual ~VideoCaptureManager();
struct DeviceEntry;
- // This data structure is a convenient wrap of a devices' name and associated
- // video capture supported formats.
- struct DeviceInfo {
- DeviceInfo();
- DeviceInfo(const media::VideoCaptureDevice::Name& name,
- const media::VideoCaptureFormats& supported_formats);
- ~DeviceInfo();
-
- media::VideoCaptureDevice::Name name;
- media::VideoCaptureFormats supported_formats;
- };
- typedef std::vector<DeviceInfo> DeviceInfos;
-
// Checks to see if |entry| has no clients left on its controller. If so,
// remove it from the list of devices, and delete it asynchronously. |entry|
// may be freed by this function.
@@ -157,9 +145,10 @@ class CONTENT_EXPORT VideoCaptureManager : public MediaStreamProvider {
media::VideoCaptureSessionId capture_session_id);
void OnClosed(MediaStreamType type,
media::VideoCaptureSessionId capture_session_id);
- void OnDevicesInfoEnumerated(MediaStreamType stream_type,
- base::ElapsedTimer* timer,
- const DeviceInfos& new_devices_info_cache);
+ void OnDevicesInfoEnumerated(
+ MediaStreamType stream_type,
+ base::ElapsedTimer* timer,
+ const media::VideoCaptureDeviceInfos& new_devices_info_cache);
// Finds a DeviceEntry by its device ID and type, if it is already opened.
DeviceEntry* GetDeviceEntryForMediaStreamDevice(
@@ -180,9 +169,10 @@ class CONTENT_EXPORT VideoCaptureManager : public MediaStreamProvider {
// devices in the system |names_snapshot|. Retrieves the supported formats of
// the new devices and sends the new cache to OnDevicesInfoEnumerated().
void ConsolidateDevicesInfoOnDeviceThread(
- base::Callback<void(const DeviceInfos&)> on_devices_enumerated_callback,
+ base::Callback<void(const media::VideoCaptureDeviceInfos&)>
+ on_devices_enumerated_callback,
MediaStreamType stream_type,
- const DeviceInfos& old_device_info_cache,
+ const media::VideoCaptureDeviceInfos& old_device_info_cache,
scoped_ptr<media::VideoCaptureDevice::Names> names_snapshot);
// Creates and Starts a new VideoCaptureDevice, storing the result in
@@ -198,8 +188,9 @@ class CONTENT_EXPORT VideoCaptureManager : public MediaStreamProvider {
// |entry->video_capture_device|.
void DoStopDeviceOnDeviceThread(DeviceEntry* entry);
- DeviceInfo* FindDeviceInfoById(const std::string& id,
- DeviceInfos& device_vector);
+ media::VideoCaptureDeviceInfo* FindDeviceInfoById(
+ const std::string& id,
+ media::VideoCaptureDeviceInfos& device_vector);
void SetDesktopCaptureWindowIdOnDeviceThread(DeviceEntry* entry,
gfx::NativeViewId window_id);
@@ -260,7 +251,7 @@ class CONTENT_EXPORT VideoCaptureManager : public MediaStreamProvider {
// this list in OnDevicesInfoEnumerated(). GetDeviceSupportedFormats() will
// use this list if the device is not started, otherwise it will retrieve the
// active device capture format from the VideoCaptureController associated.
- DeviceInfos devices_info_cache_;
+ media::VideoCaptureDeviceInfos devices_info_cache_;
// Accessed on the device thread only.
std::map<media::VideoCaptureSessionId, gfx::NativeViewId>
« no previous file with comments | « content/browser/media/media_internals_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698