Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: site_scons/site_tools/naclsdk.py

Issue 616813002: Non-SFI Mode: Enable compiling exception_test for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: if defined() instead Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « SConstruct ('k') | tests/exception_test/direction_flag_x86.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site_scons/site_tools/naclsdk.py
diff --git a/site_scons/site_tools/naclsdk.py b/site_scons/site_tools/naclsdk.py
index dbe31281f023d6f5e1c52ac14cf766c8fe79d79c..5347a8750e4be8a89b6ddf5cdef5eb63680d6c2f 100755
--- a/site_scons/site_tools/naclsdk.py
+++ b/site_scons/site_tools/naclsdk.py
@@ -354,20 +354,22 @@ def AddBiasForPNaCl(env, temporarily_allow=True):
return
if env.Bit('target_arm'):
- env.AppendUnique(CCFLAGS=['--pnacl-arm-bias'],
- ASPPFLAGS=['--pnacl-arm-bias'])
+ bias_flag = '--pnacl-bias=arm'
elif env.Bit('target_x86_32'):
- env.AppendUnique(CCFLAGS=['--pnacl-i686-bias'],
- ASPPFLAGS=['--pnacl-i686-bias'])
+ bias_flag = '--pnacl-bias=x86-32'
elif env.Bit('target_x86_64'):
- env.AppendUnique(CCFLAGS=['--pnacl-x86_64-bias'],
- ASPPFLAGS=['--pnacl-x86_64-bias'])
+ bias_flag = '--pnacl-bias=x86-64'
elif env.Bit('target_mips32'):
- env.AppendUnique(CCFLAGS=['--pnacl-mips-bias'],
- ASPPFLAGS=['--pnacl-mips-bias'])
+ bias_flag = '--pnacl-bias=mips32'
else:
raise Exception("Unknown architecture!")
+ if env.Bit('nonsfi_nacl'):
+ bias_flag += '-nonsfi'
+
+ env.AppendUnique(CCFLAGS=[bias_flag],
+ ASPPFLAGS=[bias_flag])
+
def ValidateSdk(env):
checkables = ['${NACL_SDK_INCLUDE}/stdio.h']
« no previous file with comments | « SConstruct ('k') | tests/exception_test/direction_flag_x86.S » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698