Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/browser/importer/firefox_importer_browsertest.cc

Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed keyword autogeneration logic from CreateTemplateURL. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/firefox_importer_browsertest.cc
diff --git a/chrome/browser/importer/firefox_importer_browsertest.cc b/chrome/browser/importer/firefox_importer_browsertest.cc
index 2bd2af158afd684d7362b4a87beb7c7f06817694..e4c380209ff38cbd268121f704df13187c587e03 100644
--- a/chrome/browser/importer/firefox_importer_browsertest.cc
+++ b/chrome/browser/importer/firefox_importer_browsertest.cc
@@ -98,6 +98,11 @@ const KeywordInfo kFirefoxKeywords[] = {
"http://www.webster.com/cgi-bin/dictionary?va={searchTerms}"},
// Search keywords.
{L"\x4E2D\x6587", L"\x4E2D\x6587", "http://www.google.com/"},
+ {L"keyword", L"keyword", "http://example.{searchTerms}.com/"},
+ // in_process_importer_bridge.cc:CreateTemplateURL() will return NULL for
+ // the following bookmark. Consequently, it won't be imported as a search
+ // engine.
+ {L"", L"", "http://%x.example.{searchTerms}.com/"},
};
const AutofillFormDataInfo kFirefoxAutofillEntries[] = {
@@ -135,7 +140,11 @@ class FirefoxObserver : public ProfileWriter,
EXPECT_EQ(arraysize(kFirefoxBookmarks), bookmark_count_);
EXPECT_EQ(1U, history_count_);
EXPECT_EQ(arraysize(kFirefoxPasswords), password_count_);
- EXPECT_EQ(arraysize(kFirefoxKeywords), keyword_count_);
+ // The following test case from |kFirefoxKeywords| won't be imported:
+ // "http://%x.example.{searchTerms}.com/"}.
+ // Hence, value of |keyword_count_| should be lower than size of
+ // |kFirefoxKeywords| by 1.
+ EXPECT_EQ(arraysize(kFirefoxKeywords) - 1, keyword_count_);
}
bool BookmarkModelIsLoaded() const override {

Powered by Google App Engine
This is Rietveld 408576698