Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: chrome/utility/importer/bookmark_html_reader_unittest.cc

Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/importer/bookmark_html_reader_unittest.cc
diff --git a/chrome/utility/importer/bookmark_html_reader_unittest.cc b/chrome/utility/importer/bookmark_html_reader_unittest.cc
index 47ae53e7fbe1ea1aa54f0bf0d2643c2d66aeba6b..5f190dd0d584dbd2973172f1f6e61206f7121a3e 100644
--- a/chrome/utility/importer/bookmark_html_reader_unittest.cc
+++ b/chrome/utility/importer/bookmark_html_reader_unittest.cc
@@ -152,6 +152,7 @@ class BookmarkHTMLReaderTestWithData : public testing::Test {
void ExpectFirstFirefox23Bookmark(const ImportedBookmarkEntry& entry);
void ExpectSecondFirefox23Bookmark(const ImportedBookmarkEntry& entry);
void ExpectThirdFirefox23Bookmark(const ImportedBookmarkEntry& entry);
+ void ExpectFirefoxBookmarkWithKeyword(const importer::URLKeywordInfo& info);
base::FilePath test_data_path_;
};
@@ -236,6 +237,13 @@ void BookmarkHTMLReaderTestWithData::ExpectThirdFirefox23Bookmark(
EXPECT_EQ("http://code.google.com/p/chromium/codesearch", entry.url.spec());
}
+void BookmarkHTMLReaderTestWithData::ExpectFirefoxBookmarkWithKeyword(
+ const importer::URLKeywordInfo& info) {
+ EXPECT_EQ(ASCIIToUTF16("http://example.%s.com/"), info.raw_url);
+ EXPECT_EQ(ASCIIToUTF16("keyword"), info.keyword);
+ EXPECT_EQ(ASCIIToUTF16("Bookmark Keyword"), info.display_name);
+}
+
} // namespace
TEST_F(BookmarkHTMLReaderTestWithData, Firefox2BookmarkFileImport) {
@@ -244,7 +252,7 @@ TEST_F(BookmarkHTMLReaderTestWithData, Firefox2BookmarkFileImport) {
std::vector<ImportedBookmarkEntry> bookmarks;
ImportBookmarksFile(base::Callback<bool(void)>(),
base::Callback<bool(const GURL&)>(),
- path, &bookmarks, NULL);
+ path, &bookmarks, NULL, NULL);
ASSERT_EQ(3U, bookmarks.size());
ExpectFirstFirefox2Bookmark(bookmarks[0]);
@@ -258,7 +266,7 @@ TEST_F(BookmarkHTMLReaderTestWithData, BookmarkFileWithHrTagImport) {
std::vector<ImportedBookmarkEntry> bookmarks;
ImportBookmarksFile(base::Callback<bool(void)>(),
base::Callback<bool(const GURL&)>(),
- path, &bookmarks, NULL);
+ path, &bookmarks, NULL, NULL);
ASSERT_EQ(3U, bookmarks.size());
ExpectFirstFirefox23Bookmark(bookmarks[0]);
@@ -272,13 +280,26 @@ TEST_F(BookmarkHTMLReaderTestWithData, EpiphanyBookmarkFileImport) {
std::vector<ImportedBookmarkEntry> bookmarks;
ImportBookmarksFile(base::Callback<bool(void)>(),
base::Callback<bool(const GURL&)>(),
- path, &bookmarks, NULL);
+ path, &bookmarks, NULL, NULL);
ASSERT_EQ(2U, bookmarks.size());
ExpectFirstEpiphanyBookmark(bookmarks[0]);
ExpectSecondEpiphanyBookmark(bookmarks[1]);
}
+TEST_F(BookmarkHTMLReaderTestWithData, FirefoxBookmarkFileWithKeywordImport) {
+ base::FilePath path = test_data_path_.AppendASCII(
+ "firefox_bookmark_keyword.html");
+
+ std::vector<importer::URLKeywordInfo> search_engines;
+ ImportBookmarksFile(base::Callback<bool(void)>(),
+ base::Callback<bool(const GURL&)>(),
+ path, NULL, &search_engines, NULL);
+
+ ASSERT_EQ(1U, search_engines.size());
+ ExpectFirefoxBookmarkWithKeyword(search_engines[0]);
+}
+
namespace {
class CancelAfterFifteenCalls {
@@ -301,7 +322,7 @@ TEST_F(BookmarkHTMLReaderTestWithData, CancellationCallback) {
ImportBookmarksFile(base::Bind(&CancelAfterFifteenCalls::ShouldCancel,
base::Unretained(&cancel_fifteen)),
base::Callback<bool(const GURL&)>(),
- path, &bookmarks, NULL);
+ path, &bookmarks, NULL, NULL);
// The cancellation callback is checked before each line is read, so fifteen
// lines are imported. The first fifteen lines of firefox2.html include only
@@ -326,7 +347,7 @@ TEST_F(BookmarkHTMLReaderTestWithData, ValidURLCallback) {
std::vector<ImportedBookmarkEntry> bookmarks;
ImportBookmarksFile(base::Callback<bool(void)>(),
base::Bind(&IsURLValid),
- path, &bookmarks, NULL);
+ path, &bookmarks, NULL, NULL);
ASSERT_EQ(2U, bookmarks.size());
ExpectFirstFirefox2Bookmark(bookmarks[0]);

Powered by Google App Engine
This is Rietveld 408576698