chrome/common/importer/importer_data_types.h - Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/importer/importer_data_types.h

Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/importer/in_process_importer_bridge.cc ('K') | « chrome/browser/importer/in_process_importer_bridge.cc ('k') | chrome/common/importer/profile_import_process_param_traits_macros.h » ('j') | chrome/utility/importer/bookmark_html_reader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/importer/importer_data_types.h

diff --git a/chrome/common/importer/importer_data_types.h b/chrome/common/importer/importer_data_types.h

index d9594e76d08b4c5cb643ce808a8dde78a3cfb910..e6e9d92ae8e1c6738c50807c314e0c02d87363d7 100644

--- a/chrome/common/importer/importer_data_types.h

+++ b/chrome/common/importer/importer_data_types.h

@@ -49,9 +49,9 @@ struct SourceProfile {

// Contains information needed for importing bookmarks/search engine urls, etc.

Peter Kasting 2014/10/07 23:17:38 Is this comment still accurate? It seems like thi

Tapu Ghose 2014/10/12 00:58:20 Done.

struct URLKeywordInfo {

- GURL url;

base::string16 keyword;

base::string16 display_name;

+ base::string16 raw_url;

Peter Kasting 2014/10/07 23:17:38 Nit: Why are you moving this to the bottom? Leave

Tapu Ghose 2014/10/12 00:58:20 Done.

};

#if defined(OS_WIN)