Chromium Code Reviews| Index: chrome/common/importer/importer_data_types.h |
| diff --git a/chrome/common/importer/importer_data_types.h b/chrome/common/importer/importer_data_types.h |
| index d9594e76d08b4c5cb643ce808a8dde78a3cfb910..a12834e971c1d93ad46567e011068fe535f1a043 100644 |
| --- a/chrome/common/importer/importer_data_types.h |
| +++ b/chrome/common/importer/importer_data_types.h |
| @@ -47,9 +47,13 @@ struct SourceProfile { |
| std::string locale; |
| }; |
| -// Contains information needed for importing bookmarks/search engine urls, etc. |
| -struct URLKeywordInfo { |
| - GURL url; |
| +// Contains information needed for importing search engine urls. |
| +struct SearchEngineInfo { |
| + // GURL derived from an url will be invalid if the url contains replacement |
| + // terms(s) in host (e.g., http://example.%s.com). Since |url| may contain |
| + // replacement term(s) in the host, |url| is stored as a string rather than as |
| + // a GURL. |
|
Peter Kasting
2014/11/11 22:42:11
Nit: How about just:
|url| is a string instead
Tapu Ghose
2014/11/15 05:22:19
Done.
Peter Kasting
2014/11/17 21:30:35
No, I meant use my proposal for the entire comment
Tapu Ghose
2014/12/07 02:49:54
I see.
|
| + base::string16 url; |
| base::string16 keyword; |
| base::string16 display_name; |
| }; |