chrome/utility/importer/external_process_importer_bridge.cc - Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/external_process_importer_bridge.cc

Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replacing custom code by existing function for checking if an url supports replacement terms. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/utility/importer/bookmarks_file_importer.cc ('K') | « chrome/utility/importer/external_process_importer_bridge.h ('k') | chrome/utility/importer/firefox_importer.cc » ('j') | chrome/utility/importer/firefox_importer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/external_process_importer_bridge.cc

diff --git a/chrome/utility/importer/external_process_importer_bridge.cc b/chrome/utility/importer/external_process_importer_bridge.cc

index fcfc61f20b1a4331d8a5ae2f4cf7a6f707e65164..de7cb93c43da4b3932299314d693c87d082d2615 100644

--- a/chrome/utility/importer/external_process_importer_bridge.cc

+++ b/chrome/utility/importer/external_process_importer_bridge.cc

@@ -134,10 +134,10 @@ void ExternalProcessImporterBridge::SetHistoryItems(

}

void ExternalProcessImporterBridge::SetKeywords(

- const std::vector<importer::URLKeywordInfo>& url_keywords,

+ const std::vector<importer::SearchEngineInfo>& search_engines,

bool unique_on_host_and_path) {

Send(new ProfileImportProcessHostMsg_NotifyKeywordsReady(

- url_keywords, unique_on_host_and_path));

+ search_engines, unique_on_host_and_path));

}

void ExternalProcessImporterBridge::SetFirefoxSearchEnginesXMLData(