chrome/common/importer/importer_data_types.h - Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/importer/importer_data_types.h

Issue 616763002: Importing certain bookmarks from firefox and HTML file as search engines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replacing custom code by existing function for checking if an url supports replacement terms. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/importer/in_process_importer_bridge.cc ('K') | « chrome/common/importer/importer_bridge.h ('k') | chrome/common/importer/profile_import_process_messages.h » ('j') | chrome/utility/importer/bookmark_html_reader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/importer/importer_data_types.h

diff --git a/chrome/common/importer/importer_data_types.h b/chrome/common/importer/importer_data_types.h

index d9594e76d08b4c5cb643ce808a8dde78a3cfb910..2e4c0df5fd8e4aff63695acf05666ff668f74cd1 100644

--- a/chrome/common/importer/importer_data_types.h

+++ b/chrome/common/importer/importer_data_types.h

@@ -47,9 +47,12 @@ struct SourceProfile {

std::string locale;

};

-// Contains information needed for importing bookmarks/search engine urls, etc.

-struct URLKeywordInfo {

- GURL url;

+// Contains information needed for importing search engine urls.

+struct SearchEngineInfo {

+// GURL derived from an url will be invalid if the url contains replacement

+// terms(s) in host (e.g., http://example.%s.com). Since |url| may contain

Ilya Sherman 2014/11/07 00:22:34 nit: Is "%s" still the up-to-date string?

Tapu Ghose 2014/11/09 14:03:06 In this case yes. However, "%s" is replaced with "

+// replacement term(s) in host, |url| is chosen as string instead of GURL.

Ilya Sherman 2014/11/07 00:22:34 nit: "is chose as string instead of GURL" -> "is s

Ilya Sherman 2014/11/07 00:22:34 nit: Please indent these comment lines two spaces

Ilya Sherman 2014/11/07 00:22:34 nit: "in host" -> "in the host"

Tapu Ghose 2014/11/09 14:03:06 Done.

+ base::string16 url;

base::string16 keyword;

base::string16 display_name;

};