Importing certain bookmarks from firefox and HTML file as search engines.

chrome/browser/importer/firefox_importer_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
@@ skipping 80 matching lines @@
      "http://en.wikipedia.org/wiki/Special:Search?search={searchTerms}"},
     {L"search.yahoo.com", L"search.yahoo.com",
      "http://search.yahoo.com/search?p={searchTerms}&ei=UTF-8"},
     {L"flickr.com", L"flickr.com",
      "http://www.flickr.com/photos/tags/?q={searchTerms}"},
     {L"imdb.com", L"imdb.com", "http://www.imdb.com/find?q={searchTerms}"},
     {L"webster.com", L"webster.com",
      "http://www.webster.com/cgi-bin/dictionary?va={searchTerms}"},
     // Search keywords.
     {L"\x4E2D\x6587", L"\x4E2D\x6587", "http://www.google.com/"},
+    {L"keyword", L"keyword", "http://example.{searchTerms}.com/"},
+    // CreateTemplateURL will return NULL for the following bookmark.

[Peter Kasting, 2014/12/09 23:10:18]

Nit: Since "CreateTemplateURL" doesn't otherwise appear in this file, a reader
may not know what it refers to.  I would write
"in_process_importer_bridge.cc:CreateTemplateURL()".

[Tapu Ghose, 2014/12/10 04:41:55]

Done.

+    // Consequently, it won't be imported as search engine.

[Peter Kasting, 2014/12/09 23:10:18]

Nit: as -> as a

[Tapu Ghose, 2014/12/10 04:41:55]

Done.

Realized that we may not have any cases that would return NULL from
"CreateTemplateURL". CreateTemplateURL returns NULL in two cases:

1. passing emtpy url
2. invalid url is encountered while autogenerating keyword

Case 1 will never be reached as the condition is already handled by
"url.is_valid()" or "CanImportURLAsSearchEngine".

Case 2 won't be reached as we do not import bookmark if there is no associated
keyword. Hence, no need to autogenerate keyword.

Having said that....I think we can completely eliminate this particular test
case. Removing this test case....Please let me know if you want me to re-add the
test case.

[Peter Kasting, 2014/12/10 17:41:16]

We should probably still have the test, as we don't have any other tests in here
of invalid input URLs.

[Tapu Ghose, 2014/12/11 03:12:21]

Acknowledged.

+    {L"", L"", "http://%x.example.{searchTerms}.com/"},
 };
 
 const AutofillFormDataInfo kFirefoxAutofillEntries[] = {
     {"name", "John"},
     {"address", "#123 Cherry Ave"},
     {"city", "Mountain View"},
     {"zip", "94043"},
     {"n300", "+1 (408) 871-4567"},
     {"name", "john"},
     {"name", "aguantó"},
@@ skipping 17 matching lines @@
 
   // importer::ImporterProgressObserver:
   void ImportStarted() override {}
   void ImportItemStarted(importer::ImportItem item) override {}
   void ImportItemEnded(importer::ImportItem item) override {}
   void ImportEnded() override {
     base::MessageLoop::current()->Quit();
     EXPECT_EQ(arraysize(kFirefoxBookmarks), bookmark_count_);
     EXPECT_EQ(1U, history_count_);
     EXPECT_EQ(arraysize(kFirefoxPasswords), password_count_);
-    EXPECT_EQ(arraysize(kFirefoxKeywords), keyword_count_);
+    // The following test case from |kFirefoxKeywords| won't be imported:
+    //   "http://%x.example.{searchTerms}.com/"}.
+    // Hence, value of |keyword_count_| should be lower than size of
+    // |kFirefoxKeywords| by 1.
+    EXPECT_EQ(arraysize(kFirefoxKeywords) - 1, keyword_count_);
   }
 
   bool BookmarkModelIsLoaded() const override {
     // Profile is ready for writing.
     return true;
   }
 
   bool TemplateURLServiceIsLoaded() const override { return true; }
 
   void AddPasswordForm(const autofill::PasswordForm& form) override {
@@ skipping 177 matching lines @@
   scoped_refptr<FirefoxObserver> observer(new FirefoxObserver(false));
   FirefoxImporterBrowserTest(
       "firefox35_profile", observer.get(), observer.get());
 }
 
 IN_PROC_BROWSER_TEST_F(FirefoxProfileImporterBrowserTest,
                        MAYBE_IMPORTER(FirefoxImporter)) {
   scoped_refptr<FirefoxObserver> observer(new FirefoxObserver(true));
   FirefoxImporterBrowserTest("firefox_profile", observer.get(), observer.get());
 }