Importing certain bookmarks from firefox and HTML file as search engines.

chrome/browser/importer/in_process_importer_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/importer/in_process_importer_bridge.h"
 
 #include "base/bind.h"
 #include "base/debug/dump_without_crashing.h"
 #include "base/files/file_util.h"
 #include "base/strings/string_util.h"
@@ skipping 83 matching lines @@
         low_value.find("moz:") != std::string::npos) {
       return false;
     }
     return true;
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FirefoxURLParameterFilter);
 };
 
-// Creates a TemplateURL with the |keyword| and |url|. |title| may be empty.
+// Creates a TemplateURL with the |keyword| and |raw_url|. |title| may be empty.

[Peter Kasting, 2014/10/07 23:17:38]

This comment should probably also talk about what constraints, if any, apply to
the keyword and URL.

[Tapu Ghose, 2014/10/12 00:58:20]

Done.

 // This function transfers ownership of the created TemplateURL to the caller.
 TemplateURL* CreateTemplateURL(const base::string16& title,
                                const base::string16& keyword,
-                               const GURL& url) {
-  // Skip if the url is invalid.
-  if (!url.is_valid())
+                               const base::string16& raw_url) {

[Ilya Sherman, 2014/10/07 22:08:22]

nit: You might as well drop the "raw" prefix at this point.  Or, if you want to
emphasize that the URL might not be valid, I'd name this something like
"possibly_invalid_url".

[Tapu Ghose, 2014/10/12 00:58:20]

Dropped "raw" prefix. Here, the url can be either valid or invalid. Hence, not
naming it as "possibly_invalid_url".

+  // Skip if the |raw_url| is empty.

[Peter Kasting, 2014/10/07 23:17:38]

This comment just restates the code.  Instead, if a comment is needed, say _why_
the URL might be empty.

[Tapu Ghose, 2014/10/12 00:58:20]

Agree with you.

+  if (raw_url.empty())
     return NULL;
 
   TemplateURLData data;
   if (keyword.empty())
-    data.SetKeyword(TemplateURL::GenerateKeyword(url));
+    data.SetKeyword(TemplateURL::GenerateKeyword(GURL(raw_url)));

[Peter Kasting, 2014/10/07 23:17:38]

This assumes that |raw_url| will construct a valid GURL.  Is that assumption
guaranteed?  See also comments in importer_data_types.h.

[Tapu Ghose, 2014/10/12 00:58:20]

The assumption is not guaranteed. Updated logic so address it.

   else
     data.SetKeyword(keyword);
   // We set short name by using the title if it exists.
   // Otherwise, we use the shortcut.
   data.short_name = title.empty() ? keyword : title;
-  data.SetURL(
-      TemplateURLRef::DisplayURLToURLRef(base::UTF8ToUTF16(url.spec())));
+  data.SetURL(TemplateURLRef::DisplayURLToURLRef(raw_url));
   return new TemplateURL(data);
 }
 
 // Parses the OpenSearch XML files in |xml_files| and populates |search_engines|
 // with the resulting TemplateURLs.
 void ParseSearchEnginesFromFirefoxXMLData(
     const std::vector<std::string>& xml_data,
     std::vector<TemplateURL*>* search_engines) {
   DCHECK(search_engines);
 
@@ skipping 98 matching lines @@
 }
 
 void InProcessImporterBridge::SetKeywords(
     const std::vector<importer::URLKeywordInfo>& url_keywords,
     bool unique_on_host_and_path) {
   ScopedVector<TemplateURL> owned_template_urls;
   for (size_t i = 0; i < url_keywords.size(); ++i) {
     owned_template_urls.push_back(
         CreateTemplateURL(url_keywords[i].display_name,
                           url_keywords[i].keyword,
-                          url_keywords[i].url));
+                          url_keywords[i].raw_url));
   }
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
       base::Bind(&ProfileWriter::AddKeywords, writer_,
                  base::Passed(&owned_template_urls), unique_on_host_and_path));
 }
 
 void InProcessImporterBridge::SetFirefoxSearchEnginesXMLData(
     const std::vector<std::string>& search_engine_data) {
   std::vector<TemplateURL*> search_engines;
   ParseSearchEnginesFromFirefoxXMLData(search_engine_data, &search_engines);
@@ skipping 56 matching lines @@
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&ExternalProcessImporterHost::NotifyImportEnded, host_));
 }
 
 base::string16 InProcessImporterBridge::GetLocalizedString(int message_id) {
   return l10n_util::GetStringUTF16(message_id);
 }
 
 InProcessImporterBridge::~InProcessImporterBridge() {}