Importing certain bookmarks from firefox and HTML file as search engines.

chrome/utility/importer/bookmarks_file_importer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/importer/bookmarks_file_importer.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
+namespace bookmark_html_reader {
+
+bool CanImportURLAsSearchEngine(const GURL& url, base::string16* decoded_url);
+
+} // namespace namespace bookmark_html_reader

[Ilya Sherman, 2014/09/30 20:54:13]

nit: Why is this needed?  Can you #include the appropriate header instead?

[Tapu Ghose, 2014/10/07 02:02:44]

Removed.

+
 namespace internal {
 
 bool CanImportURL(const GURL& url);
 
 }  // namespace internal
 
+

[Ilya Sherman, 2014/09/30 20:54:12]

nit: Please revert this diff.

[Tapu Ghose, 2014/10/07 02:02:44]

Done.

 TEST(BookmarksFileImporterTest, CanImportURL) {
   struct TestCase {
     const std::string url;
     const bool can_be_imported;
   } test_cases[] = {
     { "http://www.example.com", true },
     { "https://www.example.com", true },
     { "ftp://www.example.com", true },
     { "aim:GoIm?screenname=myscreenname&message=hello", true },
     { "chrome://version", true },
     { "chrome://chrome-urls", true },
     { "chrome://kill", true },
     { "chrome://chrome", true },
     { "chrome://about", true },
     { "about:version", true },
     { "about:blank", true },
     { "about:credits", true },
     { "wyciwyg://example.com", false },
     { "place://google.com", false },
     { "about:config", false },
     { "about:moon", false },
   };
 
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
     EXPECT_EQ(test_cases[i].can_be_imported,
-              internal::CanImportURL(GURL(test_cases[i].url)));
+       internal::CanImportURL(GURL(test_cases[i].url)));

[Ilya Sherman, 2014/09/30 20:54:12]

nit: Please revert this diff.

[Tapu Ghose, 2014/10/07 02:02:44]

Done.

   }
 }
+
+TEST(BookmarksFileImporterTest, CanImportURLAsSearchEngine) {
+  struct TestCase {
+    const std::string url;
+    const bool can_be_imported_as_search_engine;
+  } test_cases[] = {
+    { "http://www.example.%s.com", true },
+    { "wyciwyg://example.%s.com", false },
+  };
+
+  base::string16 decoded_url;
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
+    EXPECT_EQ(test_cases[i].can_be_imported_as_search_engine,
+        bookmark_html_reader::CanImportURLAsSearchEngine(
+            GURL(test_cases[i].url), &decoded_url));
+  }

[Ilya Sherman, 2014/09/30 20:54:13]

This test code belongs in the bookmark_html_reader_unittest.cc file.  Also, you
should test the public API, rather than testing just this helper method.

[Tapu Ghose, 2014/10/07 02:02:44]

Removed. Corresponding test code is added to bookmark_html_reader_unittest.cc.

+}