Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 616743002: Check the warning "type" correctly for SSL warnings (Closed)

Created:
6 years, 2 months ago by felt
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check the warning "type" correctly for SSL warnings After some refactoring work, the SSL warning JS code was no longer checking the warning "type" correctly. This CL fixes that. BUG=418851 Committed: https://crrev.com/f6a69f4e743a9e3147fc95b55ca76ba3e3040f37 Cr-Commit-Position: refs/heads/master@{#297393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/security_warnings/ssl.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
felt
bauerb@, PTAL. Tiny CL for a bugfix
6 years, 2 months ago (2014-09-30 03:01:46 UTC) #2
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-09-30 08:43:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616743002/1
6 years, 2 months ago (2014-09-30 08:59:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as eb5fc1e3a6af7d5bd86e7bbd0c12ab63591f8221
6 years, 2 months ago (2014-09-30 09:43:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 09:44:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6a69f4e743a9e3147fc95b55ca76ba3e3040f37
Cr-Commit-Position: refs/heads/master@{#297393}

Powered by Google App Engine
This is Rietveld 408576698